fix(button): restrict transitions to relevant properties #6901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit de05751 |
|
Deploy preview for carbon-components-react ready! Built with commit de05751 https://deploy-preview-6901--carbon-components-react.netlify.app |
|
bump @aledavila @tw15egan when you all have a sec today 👀 |
tw15egan
approved these changes
Sep 24, 2020
50 tasks
aledavila
approved these changes
Sep 24, 2020
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6823
This PR specifies the properties for Carbon button transitions so that they do not interfere with focus logic inside the interactive tooltips
Changelog
Changed
transitionTesting / Reviewing
Set the button in the tooltip menu as the primary focus element and confirm that it is automatically focused when the tooltip is opened