fix(a11y): fixing Selectable Tile HCM accessibility #6932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit a1eda2a |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit a1eda2a https://deploy-preview-6932--carbon-components-react.netlify.app |
|
Looks good! Can we also fix the
|
|
@tw15egan Fixed :) |
|
FF looks good ✅ |
andreancardona
suggested changes
Oct 1, 2020
|
@andreancardona this is what I'm getting on my Win10 machine running Edge. Wondering if this is a parallels issue? cc @dakahn since I know he's running Windows
|
|
dakahn
approved these changes
Oct 2, 2020
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6895
Fixing Selectable Tile focus state and icons indicating a selection in Hight Contrast Mode
Changelog
Changed
Selectable Tile component
Testing / Reviewing
On a Windows 10 machine, go to
settings --> ease of access --> high contrastand flick the switch. Compare the storybook in Edge (Should be in High Contrast) to Chrome (Should look normal).For Firefox, you'll need to open it up and type
about:configinto the address bar. Then, search forlayout.css.prefers-contrastand set it totrue.