Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(accordion): add size variants to Accordion #7038

Merged
merged 2 commits into from
Oct 15, 2020
Merged

feat(accordion): add size variants to Accordion #7038

merged 2 commits into from
Oct 15, 2020

Conversation

tw15egan
Copy link
Member

Related to #5455

Adds in sm (32px) and xl (48px) variants to Accordion

Changelog

New

  • size prop added to Accordion. Adds in two variants sm and xl.

Changed

  • Updated snapshots

Testing / Reviewing

Ensure all size variants look correct

@tw15egan tw15egan requested review from a team as code owners October 13, 2020 18:09
@tw15egan tw15egan requested review from a team and johnbister and removed request for a team October 13, 2020 18:10
@netlify
Copy link

netlify bot commented Oct 13, 2020 •
edited

Deploy preview for carbon-elements ready!

Built with commit fc94749

https://deploy-preview-7038--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Oct 13, 2020 •
edited

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit fc94749

https://deploy-preview-7038--carbon-components-react.netlify.app

emyarod
emyarod approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me pending visual review

jeanservaas
jeanservaas reviewed Oct 14, 2020
View reviewed changes
Copy link
Contributor

@jeanservaas jeanservaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and I want to approve. I just have one question, is it possible to call this a "Large" variant vs. an "Extra Large" variant? Since we're starting to add large variants everywhere, we should be consistent. The 64px button variant is only called "Large" and the 48px search I believe might even be default.

Thoughts on this?

@tw15egan
Copy link
Member Author

@jeanservaas we'll be able to do that on the next major release, but right now we're just aligning it to all the other form input sizes (sm and xl). In the next major release, we'll switch to small and large as the two variants.

johnbister
johnbister approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@johnbister johnbister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird Al would be proud.

weirdal

@kodiakhq kodiakhq bot merged commit 30ce66c into carbon-design-system:master Oct 15, 2020
@tw15egan tw15egan deleted the add-accordion-sizes branch April 28, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@aledavila aledavila aledavila approved these changes

@jeanservaas jeanservaas jeanservaas approved these changes

@johnbister johnbister johnbister approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tw15egan @emyarod @aledavila @jeanservaas @johnbister