Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(react): update README #7130

Merged
merged 6 commits into from
Nov 17, 2020
Merged

Conversation

rodet
Copy link
Contributor

@rodet rodet commented Oct 26, 2020

The Carbon introduction on Medium got me started quickly, as neither the Carbon website nor the Carbon React repo helped me that quickly. I'd strongly encourage to mention it in the repo README as well as visibly on carbondesignsystem.com - or better, include the content directly into those two.

The Carbon introduction on Medium got me started quickly, as neither the Carbon website nor the Carbon React repo helped me that quickly. I'd strongly encourage to mention it in the repo README as well as visibly on carbondesignsystem.com - or better, include the content directly into those two.
@rodet rodet requested a review from a team as a code owner October 26, 2020 12:56
@netlify
Copy link

netlify bot commented Oct 26, 2020

Deploy preview for carbon-elements ready!

Built with commit a6b2a38

https://deploy-preview-7130--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Oct 26, 2020

Deploy preview for carbon-components-react ready!

Built with commit a6b2a38

https://deploy-preview-7130--carbon-components-react.netlify.app

@joshblack
Copy link
Contributor

Hey @rodet! 👋 Great suggestion, let me double-check that this is where we want to point folks and I'll also make sure to update that post with new screenshots with v10 😅 lol

@tw15egan
Copy link
Member

Great feedback! Would be great to have this added to the README. Once Josh has gone over the article and it's up to spec this is good to go 👍

Wondering if we should create a separate issue to get this added to the website (if it isn't already)

@rodet
Copy link
Contributor Author

rodet commented Oct 26, 2020 via email

@joshblack
Copy link
Contributor

Pushed up some updates, curious what you think @rodet @tw15egan @aledavila 👀

Article is up-to-date so should be good to go.

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments but otherwise looks great!

packages/react/README.md Outdated Show resolved Hide resolved
packages/react/README.md Outdated Show resolved Hide resolved
packages/react/README.md Outdated Show resolved Hide resolved
packages/react/README.md Outdated Show resolved Hide resolved
@rodet
Copy link
Contributor Author

rodet commented Nov 7, 2020

Overall it's a big improvement on the getting started experience. Thanks for the help, folks!

@joshblack
Copy link
Contributor

@tw15egan updated!

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉 👍

Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thank for adding this @rodet :)

@joshblack joshblack changed the title Proposal to mention the Carbon introduction as quick start docs(react): update README Nov 17, 2020
@joshblack joshblack merged commit e785ab4 into carbon-design-system:master Nov 17, 2020
@rodet rodet deleted the patch-1 branch November 19, 2020 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants