fix(reset): fix reset specifying anchor color

[DusanMilko]

Closes: #7206

Currently reset is setting hard hex color for anchor that is not ideal.
Color is not a token so causes issues in regards to theme

[netlify]

Deploy preview for carbon-elements ready!

Built with commit c572c43

https://deploy-preview-7216--carbon-elements.netlify.app

[netlify]

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit c572c43

https://deploy-preview-7216--carbon-components-react.netlify.app

[netlify]

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: 0302891

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fd15942eb244f0007cca5f9

😎 Browse the preview: https://deploy-preview-7216--carbon-elements.netlify.app

[netlify]

Deploy preview for carbon-components-react ready!

Built with commit 0302891

https://deploy-preview-7216--carbon-components-react.netlify.app

[andreancardona]

@DusanMilko hello! it seems the tests are failing - you will have to run yarn test -u to update the snapshot

[joshblack]

If I remember correctly, I think it's a hex value due to this token coming from the themes package. Since themes depends on type, if we had type depends on themes then we would have a cycle between the two.

[DusanMilko]

then should we remove this hard hex from the reset?

[joshblack]

@DusanMilko maybe we could swing something like:

  a {
    @if global-variable-exists($carbon--theme) and
      map-has-key($carbon--theme, 'link-01')
    {
      color: map-get($carbon--theme, 'link-01');
    } @else {
      color: #0062ff;
    }
  }

?

[tw15egan]

Do we even need to reset the color? It doesn't look like we reset any other color values?

[joshblack]

@tw15egan I think you're right that we don't need to reset colors, I assume that when the default type mixin was made it was just translating over from the v9 default styles which we could totally just drop in v11 👍

[DusanMilko]

@DusanMilko hello! it seems the tests are failing - you will have to run yarn test -u to update the snapshot

Got this error:

● Validation Error:

Preset jest-config-carbon not found.

Configuration Documentation:
https://jestjs.io/docs/configuration.html

[DusanMilko]

@joshblack why is this failing?

[tw15egan]

Error: argument $name of global-variable-exists($name) must be a string

Seems like the @if global-variable-exists($carbon--theme) and is causing it, would it work if we switch it to #{$carbon--theme}, or would this always evaluate true?

[DusanMilko]

Error: argument $name of global-variable-exists($name) must be a string

Seems like the @if global-variable-exists($carbon--theme) and is causing it, would it work if we switch it to #{$carbon--theme}, or would this always evaluate true?

Not sure, i know josh mentioned removing this possibly in carbon 11, is there a big reason we can't remove it now or atleast move out of reset and move into theme where it makes more sense? (I don't feel like its a breaking change but I differ to you)

[joshblack]

Hey all! Sorry for the delay over break, global-variable-exists takes in a string which I think is causing it to fail. Instead of global-variable-exists($carbon--theme) it would be global-variable-exists('carbon--theme')

Reference: https://sass-lang.com/documentation/modules/meta#global-variable-exists

[DusanMilko]

Hey all! Sorry for the delay over break, global-variable-exists takes in a string which I think is causing it to fail. Instead of global-variable-exists($carbon--theme) it would be global-variable-exists('carbon--theme')

Reference: https://sass-lang.com/documentation/modules/meta#global-variable-exists

Still seems to be failing