test(Link): add RTL, add a11y tests, add Accessibility Checker/Axe #7284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dakahn Awesome! Will this run with all of our other tests, or is there a specific command we can run inside |
|
Deploy preview for carbon-elements ready! Built with commit b8684c8 |
|
Deploy preview for carbon-components-react ready! Built with commit b8684c8 https://deploy-preview-7284--carbon-components-react.netlify.app |
|
@tw15egan No special command needed! Should kick off with good ol |
joshblack
suggested changes
Nov 13, 2020
Co-authored-by: Josh Black <josh@josh.black>
Co-authored-by: Josh Black <josh@josh.black>
joshblack
approved these changes
Nov 13, 2020
…7205-link-a11y-test-update
… into 7205-link-a11y-test-update
…7205-link-a11y-test-update
… into 7205-link-a11y-test-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7205
This PR adds React Testing library and various accessibility tests for link. Also adds in Accessibility Checker and creates a Jest Matcher to use it with 🏄
Changelog
Testing / Reviewing
This is a proof of concept for work we'll apply to other components later. So stylistic/formatting concerns and some amount of bike shedding is encouraged here.