-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): update package.json repository config #7290
Conversation
Deploy preview for carbon-elements ready! Built with commit 3a536de |
Deploy preview for carbon-components-react ready! Built with commit 3a536de https://deploy-preview-7290--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just had one style comment but seems perfect regardless
@tw15egan to test it locally you could run at the top-level: yarn carbon-cli sync package And it should work! Also totally feel free to commit those changes too if you want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Noticed after 05649fb that the changes were overwritten by our sync tool. This changes the CLI tool to add the correct monorepo repository structure so relative links will work on NPM
Changelog
Changed
repository
field as an object so monorepo relative paths work correctlyRemoved
Testing / Reviewing
@joshblack wasn't sure how to test this, let me know if there is something I can run to verify 馃憤