Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): update package.json repository config #7290

Merged
merged 4 commits into from
Nov 16, 2020

Conversation

tw15egan
Copy link
Member

Noticed after 05649fb that the changes were overwritten by our sync tool. This changes the CLI tool to add the correct monorepo repository structure so relative links will work on NPM

Changelog

Changed

  • Updates the CLI tool to render the repository field as an object so monorepo relative paths work correctly

Removed

  • unneeded variable

Testing / Reviewing

@joshblack wasn't sure how to test this, let me know if there is something I can run to verify 馃憤

@tw15egan tw15egan requested a review from a team as a code owner November 13, 2020 20:59
@netlify
Copy link

netlify bot commented Nov 13, 2020

Deploy preview for carbon-elements ready!

Built with commit 3a536de

https://deploy-preview-7290--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Nov 13, 2020

Deploy preview for carbon-components-react ready!

Built with commit 3a536de

https://deploy-preview-7290--carbon-components-react.netlify.app

Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just had one style comment but seems perfect regardless

packages/cli/src/commands/sync/package.js Outdated Show resolved Hide resolved
@joshblack
Copy link
Contributor

@tw15egan to test it locally you could run at the top-level:

yarn carbon-cli sync package

And it should work! Also totally feel free to commit those changes too if you want.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@kodiakhq kodiakhq bot merged commit 5f92371 into carbon-design-system:master Nov 16, 2020
@tw15egan tw15egan deleted the update-cli branch April 28, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants