chore(storybook): fix props not rendering for some components #7303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
approved these changes
Nov 17, 2020
|
Deploy preview for carbon-elements ready! Built with commit fea08e4 |
|
Deploy preview for carbon-components-react ready! Built with commit fea08e4 https://deploy-preview-7303--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit a0aabb5 |
|
Nice work! Can we just remove these blurbs since the issue is resolved now?
|
|
Deploy preview for carbon-components-react ready! Built with commit a0aabb5 https://deploy-preview-7303--carbon-components-react.netlify.app |
|
Oh yes I hadn’t noticed those |
added 3 commits
November 18, 2020 11:37
…n into storybook-prop-rendering
…storybook-prop-rendering
|
@tw15egan done. Ready for review |
aledavila
added
status: one more review 👀
and removed
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7168
Closes #7169
Changelog
Fixed:
Changed
Testing / Reviewing
Check props show up as expected
Check that storybook isn't broken