Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing dependencies to icons/pictograms #7307

Merged
merged 2 commits into from
Nov 17, 2020

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented Nov 17, 2020

Closes #7306

Adds react as a peer-dep and prop-types as a regular dep to the icon and pictogram packages.

@vpicone vpicone requested a review from a team as a code owner November 17, 2020 23:06
@netlify
Copy link

netlify bot commented Nov 17, 2020

Deploy preview for carbon-elements ready!

Built with commit a4f318d

https://deploy-preview-7307--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Nov 17, 2020

Deploy preview for carbon-components-react ready!

Built with commit a4f318d

https://deploy-preview-7307--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Nov 17, 2020

Deploy preview for carbon-elements ready!

Built with commit e85fe6a

https://deploy-preview-7307--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Nov 17, 2020

Deploy preview for carbon-components-react ready!

Built with commit e85fe6a

https://deploy-preview-7307--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit d31d7ec into carbon-design-system:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@carbon/icons-react, @carbon/pictograms-react missing dependencies
3 participants