fix(TableHeader): update sortable table header aria description for voice over #7383
Conversation
| @@ -18,24 +18,27 @@ import { sortStates } from './state/sorting'; | |||
| const { prefix } = settings; | |||
|
|
|||
| const translationKeys = { | |||
| iconDescription: 'carbon.table.header.icon.description', | |||
| buttonDescription: 'carbon.table.header.icon.description', | |||
There was a problem hiding this comment.
Note: Tried to change carbon.table.header.icon.description to carbon.table.header.button.description since this label is no longer the icon, but the button. However, I got a warning about the public api, so I left it as is.
jnm2377
changed the title
|
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: d29063d 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fc9292fb911c70008d31f54 😎 Browse the preview: https://deploy-preview-7383--carbon-elements.netlify.app |
|
✔️ Deploy preview for carbon-components-react ready! 🔨 Explore the source changes: d29063d 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/5fc9292f5ce18200080c5e51 😎 Browse the preview: https://deploy-preview-7383--carbon-components-react.netlify.app |
Closes #7369
Changelog
When tabbing/entering a header this is announced: (description of how to sort, which way it will sort/by which header (name) you are sorting).
