Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove Storybook and CodeSandbox PropType warnings #7460

Merged
merged 2 commits into from
Dec 15, 2020
Merged

docs: remove Storybook and CodeSandbox PropType warnings #7460

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1849e47
docs: remove Storybook deprecation warnings
emyarod Dec 15, 2020
ca5de9d
chore: update snapshots
emyarod Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react/examples/custom-data-table-state-manager/src/components/CustomDataTable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ const CustomDataTable = ({
onChange={handleChangeSearchString}
/>
<TableToolbarMenu tabIndex={hasBatchActions ? -1 : 0}>
<TableToolbarAction primaryFocus onClick={() => alert('Alert 1')}>
<TableToolbarAction onClick={() => alert('Alert 1')}>
Action 1
</TableToolbarAction>
<TableToolbarAction onClick={() => alert('Alert 2')}>
Expand Down
4 changes: 1 addition & 3 deletions packages/react/src/components/DataTable/DataTable-story.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,7 @@ export const WithToolbar = () => (
<TableToolbarContent>
<TableToolbarSearch onChange={onInputChange} />
<TableToolbarMenu light>
<TableToolbarAction
onClick={action('Action 1 Click')}
primaryFocus>
<TableToolbarAction onClick={action('Action 1 Click')}>
Action 1
</TableToolbarAction>
<TableToolbarAction onClick={action('Action 2 Click')}>
Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/components/DataTable/__tests__/DataTable-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ describe('DataTable', () => {
id="custom-id"
/>
<TableToolbarMenu>
<TableToolbarAction primaryFocus onClick={jest.fn()}>
<TableToolbarAction onClick={jest.fn()}>
Action 1
</TableToolbarAction>
<TableToolbarAction onClick={jest.fn()}>
Expand Down Expand Up @@ -390,7 +390,7 @@ describe('DataTable', () => {
id="custom-id"
/>
<TableToolbarMenu>
<TableToolbarAction primaryFocus onClick={jest.fn()}>
<TableToolbarAction onClick={jest.fn()}>
Action 1
</TableToolbarAction>
<TableToolbarAction onClick={jest.fn()}>
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/DataTable/stories/DataTable-batch-actions-story.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export const Usage = () => (
/>
<TableToolbarMenu
tabIndex={getBatchActionProps().shouldShowBatchActions ? -1 : 0}>
<TableToolbarAction primaryFocus onClick={() => alert('Alert 1')}>
<TableToolbarAction onClick={() => alert('Alert 1')}>
Action 1
</TableToolbarAction>
<TableToolbarAction onClick={() => alert('Alert 2')}>
Expand Down
4 changes: 1 addition & 3 deletions packages/react/src/components/DataTable/stories/DataTable-filtering-story.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,7 @@ export const Usage = () => (
{/* pass in `onInputChange` change here to make filtering work */}
<TableToolbarSearch onChange={onInputChange} />
<TableToolbarMenu>
<TableToolbarAction
onClick={action('Action 1 Click')}
primaryFocus>
<TableToolbarAction onClick={action('Action 1 Click')}>
Action 1
</TableToolbarAction>
<TableToolbarAction onClick={action('Action 2 Click')}>
Expand Down
4 changes: 1 addition & 3 deletions ...react/src/components/DataTable/stories/dynamic-content/DataTable-dynamic-content-story.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,7 @@ export const Example = (props) => {
<TableToolbarContent>
<TableToolbarSearch onChange={onInputChange} />
<TableToolbarMenu>
<TableToolbarAction
primaryFocus
onClick={this.handleOnRowAdd}>
<TableToolbarAction onClick={this.handleOnRowAdd}>
Add row
</TableToolbarAction>
<TableToolbarAction onClick={this.handleOnHeaderAdd}>
Expand Down