Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): alignment tweak based on new focus padding #8079

Merged

Conversation

tay1orjones
Copy link
Member

Closes #8061

Small tweak to center the check inside the checkbox based on the recent padding/outline updates from #7887

Changelog

Changed

  • checkbox check positioning

Testing / Reviewing

Checkbox story should show the check is horizontally centered within the checkbox with and without focus ring.

@netlify
Copy link

netlify bot commented Mar 12, 2021

Deploy preview for carbon-elements ready!

Built with commit 45cf9d0

https://deploy-preview-8079--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 12, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 45cf9d0

https://deploy-preview-8079--carbon-components-react.netlify.app

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 6441afd into carbon-design-system:main Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Checkbox]: check in box is left-aligned
3 participants