Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react): add Theme component, useTheme hook #9201

Merged
merged 8 commits into from
Jul 22, 2021
Merged

feat(react): add Theme component, useTheme hook #9201

merged 8 commits into from
Jul 22, 2021

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Jul 14, 2021 •
edited by joshblack
Loading

Closes #9183

Add Theme component for inline theming support. Add useTheme hook for accessing the current theme.

Changelog

New

  • Add Theme component
  • Add useTheme hook

Changed

  • Update entrypoint to export Theme and useTheme

Removed

Testing / Reviewing

  • Read the documentation on the Theme storybook docs page and verify it makes sense / is accurate
  • Make sure tests pass as expected

@dakahn dakahn requested a review from a team as a code owner July 14, 2021 16:18
@netlify
Copy link

netlify bot commented Jul 14, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 1c98d0d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60f997cc3615050007ae7dbc

😎 Browse the preview: https://deploy-preview-9201--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 14, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 1c98d0d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60f997ccd4f72c0007f6f86f

😎 Browse the preview: https://deploy-preview-9201--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 14, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 1c98d0d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60f997cc832cc2000906198c

😎 Browse the preview: https://deploy-preview-9201--carbon-components-react.netlify.app

@joshblack joshblack changed the title feat(Theme): add theme package feat(react): add Theme component, useTheme hook Jul 16, 2021
@joshblack joshblack marked this pull request as draft July 16, 2021 16:24
@joshblack joshblack marked this pull request as ready for review July 16, 2021 17:28
@andreancardona
Copy link
Contributor

@dakahn is this ready to be reviewed just want to confirm?

@joshblack
Copy link
Contributor

@andreancardona it's ready to go!

andreancardona
andreancardona approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@kodiakhq kodiakhq bot merged commit a67867c into carbon-design-system:main Jul 22, 2021
@dakahn dakahn mentioned this pull request Jul 23, 2021
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstrubberg sstrubberg sstrubberg approved these changes

@andreancardona andreancardona andreancardona approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build out a Theme component
4 participants
@dakahn @andreancardona @joshblack @sstrubberg