Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental-pagination): add onchange handler #9355

Merged

Conversation

tay1orjones
Copy link
Member

Closes #9313

Adds an onChange prop/handler to unstable_Pagination. The signature mirrors the callback available in the stable Pagination.

Changelog

New

  • unstable_Pagination: added onChange handler

Testing / Reviewing

In the storybook, the unstable_Pagination/Playground story should fire an onChange action when next/prev buttons are clicked.

@netlify
Copy link

netlify bot commented Jul 28, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 4de99ee

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6109ae0136af840008981431

😎 Browse the preview: https://deploy-preview-9355--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 28, 2021

❌ Deploy Preview for carbon-elements failed.

🔨 Explore the source changes: 4de99ee

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6109ae010b42a20009476d25

@netlify
Copy link

netlify bot commented Jul 28, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 4de99ee

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6109ae0136af84000898142c

😎 Browse the preview: https://deploy-preview-9355--carbon-components-react.netlify.app

Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@kodiakhq kodiakhq bot merged commit 06acc24 into carbon-design-system:main Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unstable_Pagination does not fire onChange for next and previous buttons
3 participants