-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(data-table-core): disabled link bug #9395
fix(data-table-core): disabled link bug #9395
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: ce0cc9c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/610c2c96e6f5fa000760b4e3 😎 Browse the preview: https://deploy-preview-9395--carbon-react-next.netlify.app |
❌ Deploy Preview for carbon-elements failed. 🔨 Explore the source changes: ce0cc9c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/610c2c96eeff3e000869a7bf |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: ce0cc9c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/610c2c962fedbf00087f86f1 😎 Browse the preview: https://deploy-preview-9395--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreancardona looks good 👍
When I added a previous fix for some link hover styles in data-table, I added some links for testing to the usage
story.
Maybe it would be worthwhile to modify one of those links (the ones with "disabled" text, maybe?) to actually be disabled
and leave it in as an example. It might also prevent future regressions of this. Thoughts?
Was actually thinking something similar. I just pushed up a change, let me know what you think! |
…na/carbon into 9218-data-table-disable-bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreancardona awesome! good to go once you've removed the TESTING
story
Closes #9218
data-table
that it maintains the expected disabled stylingTesting
BEFORE MERGING
to make sureTESTING
story isREMOVED
from code :)