Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-table-core): disabled link bug #9395

Merged
merged 7 commits into from
Aug 5, 2021
Merged

fix(data-table-core): disabled link bug #9395

merged 7 commits into from
Aug 5, 2021

Conversation

andreancardona
Copy link
Contributor

@andreancardona andreancardona commented Aug 3, 2021

Closes #9218

  • This PR makes sure that when the link component is disabled within the data-table that it maintains the expected disabled styling

Testing

  • Navigate to Link --> TESTING story and make sure the bug no longer exists.
  • Please make sure to ping me BEFORE MERGING to make sure TESTING story is REMOVED from code :)

@andreancardona andreancardona requested a review from a team as a code owner August 3, 2021 16:00
@andreancardona andreancardona requested review from jnm2377, dakahn and tay1orjones and removed request for jnm2377 August 3, 2021 16:00
@netlify
Copy link

netlify bot commented Aug 3, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: ce0cc9c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/610c2c96e6f5fa000760b4e3

😎 Browse the preview: https://deploy-preview-9395--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Aug 3, 2021

❌ Deploy Preview for carbon-elements failed.

🔨 Explore the source changes: ce0cc9c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/610c2c96eeff3e000869a7bf

@netlify
Copy link

netlify bot commented Aug 3, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: ce0cc9c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/610c2c962fedbf00087f86f1

😎 Browse the preview: https://deploy-preview-9395--carbon-components-react.netlify.app

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreancardona looks good 👍

When I added a previous fix for some link hover styles in data-table, I added some links for testing to the usage story.

Maybe it would be worthwhile to modify one of those links (the ones with "disabled" text, maybe?) to actually be disabled and leave it in as an example. It might also prevent future regressions of this. Thoughts?

@andreancardona
Copy link
Contributor Author

@andreancardona looks good 👍

When I added a previous fix for some link hover styles in data-table, I added some links for testing to the usage story.

Maybe it would be worthwhile to modify one of those links (the ones with "disabled" text, maybe?) to actually be disabled and leave it in as an example. It might also prevent future regressions of this. Thoughts?

Was actually thinking something similar. I just pushed up a change, let me know what you think!

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreancardona awesome! good to go once you've removed the TESTING story

@andreancardona andreancardona enabled auto-merge (squash) August 5, 2021 18:23
@andreancardona andreancardona merged commit fce08a7 into carbon-design-system:main Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color changes when mouse hover on disabled link component in table cell
4 participants