Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(carbon-react): added dependencies for better install experience #9533

Merged
merged 4 commits into from Aug 26, 2021

Conversation

sstrubberg
Copy link
Member

@sstrubberg sstrubberg commented Aug 24, 2021

Closes #9529

Added carbon-components and carbon-icons to the Dependencies for a better @carbon/react installation experience. Users should no longer receive the following warnings on install.

image

@sstrubberg sstrubberg requested a review from a team as a code owner August 24, 2021 17:31
@jnm2377
Copy link
Contributor

jnm2377 commented Aug 24, 2021

Please correct me if I'm wrong, but I thought peer dependencies still require you to install the dependencies? But actual dependencies won't need to be installed? I think the better option would be to go with dependencies in that case so people don't actually have to install these. However, if peer dependencies don't require installation on their end, then it's cool 👍🏽

@netlify
Copy link

netlify bot commented Aug 24, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 4e6d55f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6127c13cda25ff00079ddc8c

😎 Browse the preview: https://deploy-preview-9533--carbon-react-next.netlify.app/

@netlify
Copy link

netlify bot commented Aug 24, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 4e6d55f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6127c13c64f7ed0008e95f4f

😎 Browse the preview: https://deploy-preview-9533--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 24, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 4e6d55f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6127c13cf7b9270008c4066f

😎 Browse the preview: https://deploy-preview-9533--carbon-components-react.netlify.app

@sstrubberg
Copy link
Member Author

Please correct me if I'm wrong, but I thought peer dependencies still require you to install the dependencies? But actual dependencies won't need to be installed? I think the better option would be to go with dependencies in that case so people don't actually have to install these. However, if peer dependencies don't require installation on their end, then it's cool 👍🏽

thanks for the heads up!

@sstrubberg sstrubberg enabled auto-merge (squash) August 26, 2021 16:28
@sstrubberg sstrubberg merged commit e205e82 into carbon-design-system:main Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add all peer dependencies to @carbon/react for easier install
3 participants