New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Add accordion to theme #212
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://gatsby-theme-carbon-git-fork-davidicus-feat-accordion.carbon-design-system.now.sh |
Hey @davidicus thanks so much for the PR it looks great. Just a couple small things.
.accordion {
width: 100%;
@include carbon--breakpoint('md') {
width: 75%;
}
@include carbon--breakpoint('lg') {
width: 58.33%;
}
}
A couple tips: you'll need to include these at the top of your sass module to do the breakpoints/type stuff @import '~carbon-components/scss/globals/scss/vars';
@import '~@carbon/elements/scss/type/type'; Also, if you need to target a class that you don't have control over from a module you can do so with the global keyword .accordion :global(.bx--accordion__title){
title styles
}
|
@vpicone do you want me to exactly mirror the styling from that brand center implementation? If so I think I still need to add some padding on the accordion title and the focus blue state. Let me know and I will add. |
Could you elaborate on the focus blue state? I'd rather leave the padding as the Carbond default, they can modify that in the brand center site if they want. |
@davidicus Looks great! thanks for the contribution, I'll try to cut a release today or tomorrow. |
This PR adds the carbon accordion component to the gatsby carbon theme. It also adds a page to the example gatsby site included in this repo.