Themes #216
Merged
Themes #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://gatsby-theme-carbon-git-fork-vpicone-themes.carbon-design-system.now.sh |
alisonjoseph
reviewed
Jul 8, 2019
packages/gatsby-theme-carbon/src/components/Homepage/Banner.module.scss
Outdated
Show resolved
Hide resolved
alisonjoseph
reviewed
Jul 8, 2019
packages/gatsby-theme-carbon/src/components/Homepage/Callout.module.scss
Outdated
Show resolved
Hide resolved
alisonjoseph
requested changes
Jul 8, 2019
|
Does this supersede #209 ? |
|
@alisonjoseph yeah I'll make sure to bring your changes in from #209 |
|
👍 thanks! and thanks for all the cleanup work here, looks great 😄 |
alisonjoseph
reviewed
Jul 8, 2019
packages/gatsby-theme-carbon/src/components/Homepage/Callout.module.scss
Outdated
Show resolved
Hide resolved
alisonjoseph
reviewed
Jul 8, 2019
packages/gatsby-theme-carbon/src/components/Homepage/Callout.module.scss
Outdated
Show resolved
Hide resolved
alisonjoseph
requested changes
Jul 8, 2019
…odule.scss Co-Authored-By: Alison Joseph <alisonejoseph@Gmail.com>
…odule.scss Co-Authored-By: Alison Joseph <alisonejoseph@Gmail.com>
alisonjoseph
added
status: ready to merge 🎉
status: merge conflict 🚫
and removed
status: ready to merge 🎉
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the previous css-in-js styles in favor of css modules
closes #105, prepares for #213
closes #203