refactor(ErrorEmptyState): added typescript types to the component #4747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for carbon-for-ibm-products processing.
|
matthewgallo
reviewed
Apr 4, 2024
| */ | ||
| action?: { | ||
| kind?: 'primary' | 'secondary' | 'tertiary'; | ||
| renderIcon?: (() => ReactNode) | object; |
There was a problem hiding this comment.
You could use CarbonIconType here for renderIcon:
import { CarbonIconType } from '@carbon/react/icons/CarbonIcon';There was a problem hiding this comment.
thanks for the review matt, the changes are implemented.
i have used below import
import { CarbonIconType } from '@carbon/icons-react/lib/CarbonIcon';as i get "Cannot find module '@carbon/react/icons/CarbonIcon' or its corresponding type declarations." from the suggested one.
There was a problem hiding this comment.
I pulled down your branch locally and don't see that error. Lets merge this and if this pops up we can open an issue and follow up.
matthewgallo
approved these changes
Apr 10, 2024
Merged
via the queue into
carbon-design-system:main
with commit Apr 10, 2024
077f336
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #4263
added TS types to the component
What did you change?
packages/ibm-products/src/components/EmptyStates/ErrorEmptyState/ErrorEmptyState.tsx
How did you test and verify your work?
storybook renders as expected
tested locally verifying with different props