Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(PageHeader): add default state avt test #5269

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented May 20, 2024

Closes #5003

What did you change?

add e2e test for PageHeader

How did you test and verify your work?

yarn run avt

Copy link

netlify bot commented May 20, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 2ac7e8f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/665df5a4560c2e000876aa3e
😎 Deploy Preview https://deploy-preview-5269--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@emyarod emyarod force-pushed the 5003-test/pageheader-default-state-avt branch from 8fd00a7 to 2ac7e8f Compare June 3, 2024 16:56
@emyarod emyarod marked this pull request as ready for review June 3, 2024 17:01
@emyarod emyarod requested a review from a team as a code owner June 3, 2024 17:01
@emyarod emyarod requested review from kennylam and matthewgallo and removed request for a team June 3, 2024 17:01
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennylam kennylam added this pull request to the merge queue Jun 5, 2024
Merged via the queue into carbon-design-system:main with commit cfb15e6 Jun 5, 2024
17 checks passed
@emyarod emyarod deleted the 5003-test/pageheader-default-state-avt branch June 10, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default state AVT check for PageHeader
3 participants