fix(CreateTearsheet): add focus trap back to CreateTearsheet/CreateTearsheetStep
#5329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewgallo
added
component: CreateTearsheet
matthewgallo
requested review from
IgnacioBecerra and
amal-k-joy
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
via the queue into
carbon-design-system:main
with commit Jun 4, 2024
3205383
19 checks passed
makafsal
pushed a commit
to makafsal/ibm-products
that referenced
this pull request
Jun 5, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
* refactor(DataGrid): implement types for DataGrid component * refactor(DataGridContent): implement types for DataGridContent file * refactor(filterSummary): implement types * refactor(datagridContent): implement types * refactor(datagridHead): implement types * refactor(datagridBody): implement types * refactor(datagridEmptyBody): implement types * fix(datagridEmptyBody): empty state props * refactor(DatagridVirtualBody): implement types * refactor(datagridRefBody): implement types * refactor(DatagridSimpleBody): implement types * refactor(DatagridExpandedRow): implement types * refactor(DatagridHeaderRow): implement types * refactor(DatagridSlug): implement types * refactor(DatagridRow): implement types * refactor(DatagridSelectAll): implement types * refactor(DatagridSelectAllWithToggle): implement types * refactor(DatagridToolbar): implement types * refactor(DraggableEleemt): implement types * refactor(dataGrid): import carbon component props * refactor(DataGrid): reuse react-table types * refactor(DatagridHeaderRow): assign key value separately * refactor: change types according to react-table types * fix(datagrid): remove emptyState props * refactor: revert empty state props * refactor(datagrid): move index file to .ts * refactor: update type for state in all files * refactor: change row typw * chore: test issue * chore: revert test code * chore: remove condition * chore: remove condition * chore: revert condition * chore: state destructure * chore: test deployment issue 1 * chore: test deployment issue 1 * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * refactor: test deploy error * fix(DataGrid): resolve error in deployment * fix(DataGrid): resolve error on deployed version * chore(Datagrid): resolve PR comments * chore: dummy commit to rerun jobs * chore: remove unwanted line * refactor: change react-table types version * refactor: change react-table types version * chore: remove unwanted line refactor: change react-table types version refactor: change react-table types version * chore: dummy commit to rerun jobs chore: remove unwanted line refactor: change react-table types version refactor: change react-table types version chore: remove unwanted line refactor: change react-table types version refactor: change react-table types version * chore: dummy commit to rerun jobs chore: remove unwanted line refactor: change react-table types version refactor: change react-table types version chore: remove unwanted line refactor: change react-table types version refactor: change react-table types version chore: dummy commit to rerun jobs chore: remove unwanted line refactor: change react-table types version refactor: change react-table types version chore: remove unwanted line refactor: change react-table types version refactor: change react-table types version * chore(release): publish [skip ci] - @carbon/ibm-cloud-cognitive-core@2.18.3 - @carbon/ibm-products@2.41.0 - @carbon/ibm-products-styles@2.38.0 * chore(Datagrid): resolve PR comments * fix(CreateTearsheet): add focus trap behavior (#5329) * test(ExpressiveCard): add @AVT test for default state (#5393) * test(Toolbar): add default state AVT test (#5395) * fix(Coachmark): ssr issues with `instanceOf(HTMLElement)` (#5391) * fix(Coachmark): ssr issues with htmlelement * chore: remove unnecessary export * Add .whitesource configuration file (#5323) Co-authored-by: ibm-mend-app[bot] <142626574+ibm-mend-app[bot]@users.noreply.github.com> Co-authored-by: Jeff Chew <jeff.chew@gmail.com> * refactor(TagOverflowModal): add Typescript types to TagOverflowModal (#5311) * fix(Datagrid): add disable cell support (#5385) * test(ProductiveCard): add default state AVT test (#5394) * feat(FeatureFlags): add new mechanism for feature flagging using `@carbon/feature-flags` (#5204) * feat(FeatureFlags): add feature flag support using carbon package * chore: import feature flags and update lock * chore: remove console log * feat: use new feature flag system and add mdx docs * chore: add annotation component to example story * fix: remove utility hook from portal target hook * chore: rename feature-flags file * chore: remove console log * chore: add feature flag component to editable cell stories * fix: import feature flags file * fix: import feature flags in jest setup * fix: update tests * chore: remove old generated feature flags * chore: import feature flags * fix: add feature flags file as side effect * chore: add test file * chore(feature-flags): rename to match carbon naming patterns chore: dummy commit to rerun jobs chore: remove unwanted line refactor: change react-table types version refactor: change react-table types version chore: remove unwanted line refactor: change react-table types version refactor: change react-table types version chore: dummy commit to rerun jobs chore: remove unwanted line refactor: change react-table types version refactor: change react-table types version chore: remove unwanted line refactor: change react-table types version refactor: change react-table types version chore: dummy commit to rerun jobs chore: remove unwanted line refactor: change react-table types version refactor: change react-table types version chore: remove unwanted line refactor: change react-table types version refactor: change react-table types version chore: dummy commit to rerun jobs chore: remove unwanted line refactor: change react-table types version refactor: change react-table types version chore: remove unwanted line refactor: change react-table types version refactor: change react-table types version * chore: resolve merge conflict * refactor: resolve minor issues * test: resolve test issue --------- Co-authored-by: github-merge-queue <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matt Gallo <mdgallo@us.ibm.com> Co-authored-by: andrew <emyarod@users.noreply.github.com> Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu> Co-authored-by: ibm-mend-app[bot] <142626574+ibm-mend-app[bot]@users.noreply.github.com> Co-authored-by: Jeff Chew <jeff.chew@gmail.com> Co-authored-by: Anamika T S <47971732+anamikaanu96@users.noreply.github.com> Co-authored-by: Austin <aj_viens_deruisseau@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5309
Adds back the focus trap behavior in
CreateTearsheet. This was accomplished by changing thetab-indexof focusable elements based on the current step. The newuseFocushook will filter out any focusable elements (inputs, buttons, selects, textareas) if they have a tab-index of-1.I also noticed a bug in
CreateTearsheetStepwhile working on this where therefwe forward to theGridcomponent does not work because theGriddoes not forward refs, so I wrapped the component in adivso that therefcan be applied as expected.What did you change?
How did you test and verify your work?