Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tearsheet): fix behavior of selectorPrimaryFocus for stacked tearsheets #5631

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthewgallo
Copy link
Member

@matthewgallo matthewgallo commented Jul 1, 2024

Closes #5624

This addresses the issues described in #5624. It adds the same functionality added in this PR, which fixed the selectorPrimaryFocus behavior but for stacked tearsheets.

What did you change?

packages/ibm-products/src/components/Tearsheet/TearsheetShell.tsx

How did you test and verify your work?

Storybook

Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 65670da
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66831114dee05a00084850e8
😎 Deploy Preview https://deploy-preview-5631--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewgallo matthewgallo changed the title fix(Tearsheet): focus specified els for stacked tearsheets fix(Tearsheet): fix behavior of selectorPrimaryFocus for stacked tearsheets Jul 2, 2024
@matthewgallo matthewgallo marked this pull request as ready for review July 2, 2024 14:13
@matthewgallo matthewgallo requested a review from a team as a code owner July 2, 2024 14:13
@matthewgallo matthewgallo requested review from kennylam and annawen1 and removed request for a team July 2, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tearsheets: focus with selectorPrimaryFocus and nested tearsheets is still broken
2 participants