test(testing-library): align datatest-id format with Cloud & Cognitive
#1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for ibm-security ready! 🔨 Explore the source changes: 173b01b 🔍 Inspect the deploy log: https://app.netlify.com/sites/ibm-security/deploys/6115061b17ab15000708e57d 😎 Browse the preview: https://deploy-preview-1081--ibm-security.netlify.app/ |
SimonFinney
requested review from
thekevinboyle and
dbrugger
and removed request for
lily-peng
dbrugger
reviewed
Aug 17, 2021
There was a problem hiding this comment.
I wonder does this add any value? data-testid seems to be the standard. https://testing-library.com/docs/queries/bytestid/
Here is some data from Carbon:
| Variant | Code search | Occurrences |
|---|---|---|
data-testid |
https://github.com/search?q=org%3Acarbon-design-system+data-testid&type=code | 283 |
data-test-id |
https://github.com/search?q=org%3Acarbon-design-system+data-test-id&type=code | 39 |
|
Closing in favor of carbon-design-system/ibm-products#1172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request - test(testing-library): align
datatest-idformat with Cloud & CognitiveAffected issue
Contributes to #973
Proposed change
Align
datatest-idformat with Cloud & Cognitive