Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(combo-button): prevent duplicate label error #999

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Conversation

SimonFinney
Copy link
Contributor

@SimonFinney SimonFinney commented Jun 14, 2021

Pull request - test(combo-button): prevent duplicate label error

Affected issue

Contributes to #973

Proposed change

Create unique labels for ComboButton accessibility tests to prevent duplicate label error

@SimonFinney SimonFinney requested a review from a team as a code owner June 14, 2021 13:10
@SimonFinney SimonFinney requested review from lily-peng and removed request for a team June 14, 2021 13:10
@netlify
Copy link

netlify bot commented Jun 14, 2021

✔️ Deploy Preview for ibm-security ready!

🔨 Explore the source changes: 1e1d675

🔍 Inspect the deploy log: https://app.netlify.com/sites/ibm-security/deploys/60cc5505139a0a000815066f

😎 Browse the preview: https://deploy-preview-999--ibm-security.netlify.app

@SimonFinney SimonFinney requested review from thekevinboyle and removed request for lily-peng June 14, 2021 13:19
Copy link
Contributor

@thekevinboyle thekevinboyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks good to me

@SimonFinney SimonFinney merged commit 1e1d675 into dev Jun 18, 2021
@SimonFinney SimonFinney deleted the test/combo-button branch June 18, 2021 08:11
@SimonFinney
Copy link
Contributor Author

🎉 This PR is included in version 1.43.0-prerelease.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SimonFinney
Copy link
Contributor Author

🎉 This PR is included in version 1.43.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants