feat: New tyepscript sandboxes #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tay1orjones
approved these changes
May 10, 2024
tay1orjones
reviewed
May 10, 2024
Comment on lines
+79
to
+81
| # npm lockfile | ||
| package-lock.json | ||
|
|
There was a problem hiding this comment.
This was the only other thing - the sandboxes don't need lockfiles. They should always use the most recent version of the packages specified in the package.json
tay1orjones
approved these changes
May 10, 2024
tay1orjones
temporarily deployed
to
react/v10/react-16-vite
GitHub Actions
Inactive
|
Thanks for the cleanup! will learn a lot from this!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #27
New react 18 typescript sandbox
Added:
react-18-vite-tswhich containsReact 18with vite buildpack configured withtypescriptversion 4 (same as carbon monorepo)typescript-config-carbonto package.json file