Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(component-parser): dispatched event type without detail should default to null #86

Merged
merged 3 commits into from
May 13, 2022
Merged

fix(component-parser): dispatched event type without detail should default to null #86

merged 3 commits into from
May 13, 2022

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented May 13, 2022

Currently, a dispatched event without a second argument will produce the type CustomEvent<any>.

dispatch("event");

It can be more specific; the actual type is null.

- event: CustomEvent<any>;
+ event: CustomEvent<null>;

@metonym metonym merged commit 2dc1d53 into main May 13, 2022
@metonym metonym deleted the fix-default-dispatch-type branch May 13, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@metonym