Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sample code in README #3969

Closed
josh11b opened this issue May 21, 2024 · 1 comment · Fixed by #3981
Closed

Update sample code in README #3969

josh11b opened this issue May 21, 2024 · 1 comment · Fixed by #3981
Labels
good first issue Possibly a good first issue for newcomers

Comments

@josh11b
Copy link
Contributor

josh11b commented May 21, 2024

Description of the bug:

The examples in the README need to be updated to reflect the change to package syntax from proposal #3927 .

Link to documentation:

https://github.com/carbon-language/carbon-lang/blob/trunk/README.md

What should it say instead?

package <something> api; should just be package <something>;

Any other information, logs, or outputs that you want to share?

No response
@josh11b josh11b added the good first issue Possibly a good first issue for newcomers label May 21, 2024
@ryoari
Copy link
Contributor

ryoari commented May 22, 2024

Hi @josh11b, I'm interested in this issue and have started working on updating the README to reflect the changes from proposal #3927. I'll make sure to update all relevant examples and submit a pull request soon.

@ryoari ryoari mentioned this issue May 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 23, 2024
@ryoari
Replace image file in /docs/images/ directory and update the svg edit…
e60df54 
… to reflect proposal #3927. (#3981)

Replace image file in /docs/images/ directory and update the svg editing
document to reflect the change to package syntax from proposal #3927

Closes #3969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Possibly a good first issue for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@josh11b @ryoari