Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace image file in /docs/images/ directory and update the svg edit to reflect proposal #3927. #3981

Merged
merged 4 commits into from
May 23, 2024

Conversation

ryoari
Copy link
Contributor

@ryoari ryoari commented May 23, 2024

Replace image file in /docs/images/ directory and update the svg editing document to reflect the change to package syntax from proposal #3927

Closes #3969

…ing document to reflect the change to package syntax from proposal carbon-language#3927
@github-actions github-actions bot requested a review from jonmeow May 23, 2024 20:42
@jonmeow
Copy link
Contributor

jonmeow commented May 23, 2024

In quicksort, we should probably keep the same formatting (font and colors) that was used previously. Can you please restore the changes there to those?

@jonmeow
Copy link
Contributor

jonmeow commented May 23, 2024

Note, the other two look good.

@ryoari
Copy link
Contributor Author

ryoari commented May 23, 2024

yeah looks a bit odd, I am trying to fix it while keeping the updated carbon syntax, would you mind another iteration or do you feel consistent would be better?

@ryoari

This comment was marked as resolved.

@jonmeow
Copy link
Contributor

jonmeow commented May 23, 2024

I think we really would like to keep a consistent look-and-feel. We're trying to keep a similar look as with GitHub (visible in snippets.md, in particular the dark default theme) so that it "feels" like other code snippets that would be seen in GitHub.

Note too, there's already a skew with snippets.md (the C++ parts of snippets was changed without updating images); that's a separate issue though, and this does fix #3969.

Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits here.

@jonmeow jonmeow added this pull request to the merge queue May 23, 2024
Merged via the queue into carbon-language:trunk with commit e60df54 May 23, 2024
7 checks passed
@ryoari ryoari deleted the replace-image branch May 23, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sample code in README
2 participants