Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LLVM from the repo, and clean up history. #1344

Merged
merged 19 commits into from
Jun 28, 2022
Merged

Remove LLVM from the repo, and clean up history. #1344

merged 19 commits into from
Jun 28, 2022

Conversation

chandlerc
Copy link
Contributor

@chandlerc chandlerc commented Jun 25, 2022 •
edited
Loading

This proposal establishes a plan for moving away from the embedded copy
of LLVM and instead downloading it with Bazel.

The goal is that after this lands, we will do a history-rewrite to
cleanup the repository. There are instructions on how folks can move any
in-flight work over to the newly tidied repo.

@chandlerc chandlerc added the proposal A proposal label Jun 25, 2022
@chandlerc chandlerc requested a review from a team June 25, 2022 08:58
@chandlerc chandlerc marked this pull request as ready for review June 25, 2022 10:12
@github-actions github-actions bot added the proposal rfc Proposal with request-for-comment sent out label Jun 25, 2022
@chandlerc chandlerc mentioned this pull request Jun 25, 2022
Closed
@chandlerc chandlerc linked an issue Jun 25, 2022 that may be closed by this pull request
Figure out llvm-project handling #1332
Closed
jonmeow
jonmeow reviewed Jun 25, 2022
View reviewed changes
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the http_archive direction, just some notes.

proposals/p1344.md Outdated Show resolved Hide resolved
proposals/p1344.md Outdated Show resolved Hide resolved
proposals/p1344.md Outdated Show resolved Hide resolved
proposals/p1344.md Outdated Show resolved Hide resolved
proposals/p1344.md Outdated Show resolved Hide resolved
proposals/p1344.md Show resolved Hide resolved
proposals/p1344.md Outdated Show resolved Hide resolved
@chandlerc chandlerc requested a review from a team as a code owner June 27, 2022 11:15
geoffromer
geoffromer reviewed Jun 27, 2022
View reviewed changes
proposals/p1344.md Outdated Show resolved Hide resolved
zygoloid
zygoloid reviewed Jun 27, 2022
View reviewed changes
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direction LGTM.

proposals/p1344.md Outdated Show resolved Hide resolved
chandlerc
chandlerc commented Jun 28, 2022
View reviewed changes
Copy link
Contributor Author

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be basically good-to-go with detailed steps.

proposals/p1344.md Outdated Show resolved Hide resolved
proposals/p1344.md Outdated Show resolved Hide resolved
proposals/p1344.md Outdated Show resolved Hide resolved
proposals/p1344.md Outdated Show resolved Hide resolved
proposals/p1344.md Outdated Show resolved Hide resolved
proposals/p1344.md Outdated Show resolved Hide resolved
proposals/p1344.md Outdated Show resolved Hide resolved
josh11b
josh11b reviewed Jun 28, 2022
View reviewed changes
proposals/p1344.md Outdated Show resolved Hide resolved
josh11b
josh11b reviewed Jun 28, 2022
View reviewed changes
proposals/p1344.md Outdated Show resolved Hide resolved
@chandlerc @josh11b
Update proposals/p1344.md
cc15679 
Co-authored-by: josh11b <josh11b@users.noreply.github.com>
zygoloid
zygoloid approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's do it!

@chandlerc chandlerc requested a review from jonmeow June 28, 2022 20:35
@chandlerc chandlerc merged commit 7dfea61 into carbon-language:trunk Jun 28, 2022
@chandlerc chandlerc deleted the repo-prune branch June 28, 2022 20:49
@github-actions github-actions bot added proposal accepted Decision made, proposal accepted and removed proposal rfc Proposal with request-for-comment sent out labels Jun 28, 2022
chandlerc added a commit that referenced this pull request Jun 28, 2022
@chandlerc @zygoloid
@jonmeow @josh11b
Remove LLVM from the repo, and clean up history. (#1344)
df345b5 
This proposal establishes a plan for moving away from the embedded copy
of LLVM and instead downloading it with Bazel.

The goal is that after this lands, we will do a history-rewrite to
cleanup the repository. There are instructions on how folks can move any
in-flight work over to the newly tidied repo.

Co-authored-by: Richard Smith <richard@metafoo.co.uk>
Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
Co-authored-by: josh11b <josh11b@users.noreply.github.com>
@chandlerc chandlerc added the documentation An issue or proposed change to our documentation label Jan 13, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffromer geoffromer geoffromer left review comments

@zygoloid zygoloid zygoloid approved these changes

@josh11b josh11b josh11b approved these changes

@jonmeow jonmeow jonmeow approved these changes

Assignees
No one assigned
Labels
documentation An issue or proposed change to our documentation proposal accepted Decision made, proposal accepted proposal A proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figure out llvm-project handling
5 participants
@chandlerc @zygoloid @geoffromer @josh11b @jonmeow