Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C++-like for loops #353

Merged
merged 16 commits into from
May 14, 2021
Merged

Add C++-like for loops #353

merged 16 commits into from
May 14, 2021

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Mar 5, 2021 •
edited

Add C++-like for loops

  • Omits for (;;) syntax for now.

@jonmeow jonmeow requested a review from a team March 5, 2021 23:05
@jonmeow jonmeow added WIP proposal A proposal labels Mar 5, 2021
@google-cla google-cla bot added the cla: yes PR meets CLA requirements according to bot. label Mar 5, 2021
@jonmeow jonmeow changed the title for loops for loops Mar 6, 2021
@jonmeow jonmeow added proposal rfc Proposal with request-for-comment sent out and removed WIP labels Mar 6, 2021
gribozavr
gribozavr reviewed Mar 8, 2021
View reviewed changes
proposals/p0353.md Outdated Show resolved Hide resolved
proposals/p0353.md Show resolved Hide resolved
jsiek
jsiek reviewed Mar 11, 2021
View reviewed changes
proposals/p0353.md Outdated Show resolved Hide resolved
@jonmeow @gribozavr
Update proposals/p0353.md
ae732d1 
Co-authored-by: Dmitri Gribenko <gribozavr@gmail.com>
zygoloid
zygoloid reviewed Mar 16, 2021
View reviewed changes
proposals/p0353.md Outdated Show resolved Hide resolved
proposals/p0353.md Outdated Show resolved Hide resolved
proposals/p0353.md Outdated Show resolved Hide resolved
proposals/p0353.md Show resolved Hide resolved
jonmeow and others added 2 commits March 16, 2021 13:45
@jonmeow @zygoloid
Apply suggestions from code review
0294fe9 
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
@jonmeow
alternative for in
af74052
@jonmeow jonmeow added this to All proposals in Proposals Mar 17, 2021
@jonmeow jonmeow moved this from All proposals to RFC in Proposals Mar 17, 2021
austern
austern reviewed Mar 29, 2021
View reviewed changes
proposals/p0353.md Outdated Show resolved Hide resolved
proposals/p0353.md Outdated Show resolved Hide resolved
proposals/p0353.md Outdated Show resolved Hide resolved
proposals/p0353.md Show resolved Hide resolved
proposals/p0353.md Outdated Show resolved Hide resolved
austern
austern reviewed Mar 29, 2021
View reviewed changes
proposals/p0353.md Outdated Show resolved Hide resolved
josh11b
josh11b reviewed Mar 31, 2021
View reviewed changes
Copy link
Contributor

@josh11b josh11b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonmeow jonmeow changed the title for loops Add C++-like for loops #340 Apr 13, 2021
josh11b
josh11b reviewed Apr 13, 2021
View reviewed changes
proposals/p0353.md Outdated Show resolved Hide resolved
@jonmeow jonmeow changed the title Add C++-like for loops #340 Add C++-like for loops Apr 13, 2021
@jonmeow jonmeow requested a review from a team as a code owner April 20, 2021 15:37
@jonmeow jonmeow mentioned this pull request Apr 21, 2021
Open
zygoloid
zygoloid approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great; let's move ahead with this.

proposals/p0353.md Outdated Show resolved Hide resolved
jonmeow and others added 2 commits May 14, 2021 13:54
@jonmeow @zygoloid
Update proposals/p0353.md
665168c 
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
@jonmeow
merge
519758b
@jonmeow jonmeow merged commit b996adf into carbon-language:trunk May 14, 2021
Proposals automation moved this from RFC to Accepted May 14, 2021
@jonmeow jonmeow deleted the proposal-for-loops branch May 14, 2021 22:38
@github-actions github-actions bot added proposal accepted Decision made, proposal accepted and removed proposal rfc Proposal with request-for-comment sent out labels May 14, 2021
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
@jonmeow @gribozavr
@zygoloid @austern
Add C++-like for loops (#353)
66e5083 
Add C++-like `for` loops

-  Omits `for (;;)` syntax for now.

Co-authored-by: Dmitri Gribenko <gribozavr@gmail.com>
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
Co-authored-by: austern <austern@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgodbolt mattgodbolt mattgodbolt left review comments

@gribozavr gribozavr gribozavr left review comments

@austern austern austern left review comments

@jsiek jsiek jsiek left review comments

@geoffromer geoffromer geoffromer left review comments

@josh11b josh11b josh11b left review comments

@zygoloid zygoloid zygoloid approved these changes

Assignees
No one assigned
Labels
cla: yes PR meets CLA requirements according to bot. proposal accepted Decision made, proposal accepted proposal A proposal
Projects
No open projects
Proposals
Accepted
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@jonmeow @zygoloid @mattgodbolt @gribozavr @austern @jsiek @geoffromer @josh11b @mmdriley