Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single value criteria #405

Merged

Conversation

kebringer-cb
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been added that prove the fix is effective or that the feature works.
  • New and existing tests pass locally with the changes.
  • Code follows the style guidelines of this project (PEP8, clean code, linter).
  • A self-review of the code has been done.

What is the ticket or issue number?

cbapi-4917 - add single value alert search criteria

Pull Request Description

Does this introduce a breaking change?

  • Yes
  • No

How Has This Been Tested?

Unit tests and manual e2e execution

Moved set_minimum_severity from legacy_alerts.py to alerts.py
Added set_threat_notes_present and set_alert_note_presents
@kebringer-cb kebringer-cb changed the base branch from develop to Alerts_v7_SDK_Changes September 21, 2023 03:03
@kebringer-cb kebringer-cb merged commit 645a46d into Alerts_v7_SDK_Changes Sep 21, 2023
4 checks passed
@kebringer-cb kebringer-cb deleted the cbapi-4917-single-value-criteria_v2 branch September 21, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants