added unit tests for IDS Alert type. verified IDS alert existence #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kebringer-cb
requested review from
kebringer-cb,
avanbrunt-cb,
emitreva-cb and
abowersox-cb
kebringer-cb
reviewed
Oct 5, 2023
| cbcsdk_mock.mock_request('POST', "/api/alerts/v7/orgs/test/alerts/_search", on_post) | ||
| api = cbcsdk_mock.api | ||
|
|
||
| query = api.select(Alert).where("Blort").add_criteria("type", ["INTRUSION_DETECTION_SYSTEM"])\ |
There was a problem hiding this comment.
Two additional tests - instantiate class, and class as string - select("IntrusionDetectionSystemAlert")
avanbrunt-cb
approved these changes
Oct 16, 2023
emitreva-cb
reviewed
Oct 17, 2023
emitreva-cb
reviewed
Oct 17, 2023
| request = self._build_request(0, -1, False) | ||
| del request['rows'] | ||
| request["terms"] = {"fields": fieldlist, "rows": max_rows} | ||
| url = self._build_url("/_facet") | ||
| resp = self._cb.post_object(url, body=request) | ||
| if resp.status_code == 400: | ||
| raise ApiError(resp.json()) |
There was a problem hiding this comment.
I think post_object is returning a json, is it correct to do resp.json()?
kebringer-cb
approved these changes
Oct 17, 2023
abowersox-cb
pushed a commit
that referenced
this pull request
Oct 23, 2023
* added unit tests for IDS Alert type. verified IDS alert existence * Added dependent fix for CBAPI-5061 and related tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
What is the ticket or issue number?
CPAPI-4812
CPAPI-5061
Pull Request Description
Added unit tests for IDS alerts
Added new unit tests for decomissioned functionality
Does this introduce a breaking change?
How Has This Been Tested?
manual tests and unit tests