Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBAPI-5221: Update Device Facet to support new fields #491

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

abowersox-cb
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been added that prove the fix is effective or that the feature works.
  • New and existing tests pass locally with the changes.
  • Code follows the style guidelines of this project (PEP8, clean code, linter).
  • A self-review of the code has been done.

What is the ticket or issue number?

https://jira.carbonblack.local/browse/CBAPI-5221

Pull Request Description

Update the documentation and behavior of DeviceFacet and related code to ensure proper support for all new facetable fields.

Does this introduce a breaking change?

  • Yes
  • No

How Has This Been Tested?

Unit tests pass on new code in query_devices() method; devices.py coverage now sits at 95%.

@abowersox-cb abowersox-cb merged commit 7c769f0 into feature-device-updates Mar 5, 2024
3 checks passed
@abowersox-cb abowersox-cb deleted the CBAPI-5221_device_facet_update branch March 5, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants