CBAPI-3712: guide for Device Actions #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/devices.rst
Outdated
Comment on lines
56
to
62
| # assume "api" is your CBCloudAPI reference | ||
| query = api.select(Device) | ||
| # add search terms and/or criteria to the query (not shown here) | ||
| for d in query: | ||
| do_something_with_device(d) # whatever you need for each device | ||
| while query.num_remaining > 0: | ||
| query.scroll() # default is 10,000 devices at a time |
There was a problem hiding this comment.
This is not correct you can't iterate the query then call scroll. You need to call scroll from the beginning as that also fetches the first 10k devices.
There was a problem hiding this comment.
I'm changing this example, so I hope I get it right.
There was a problem hiding this comment.
The scroll function does not act like an internal save within the query object instead it returns the results. See the docs https://carbon-black-cloud-python-sdk.readthedocs.io/en/latest/cbc_sdk.platform/#cbc_sdk.platform.devices.DeviceSearchQuery.scroll
avanbrunt-cb
requested changes
Mar 18, 2024
Already done in the last change. Just explaining why things were the way they were. |
abowersox-cb
changed the title
avanbrunt-cb
approved these changes
Mar 18, 2024
abowersox-cb
requested review from
mrangelov-cb,
hkaragitliev-cb and
emitreva-cb
kebringer-cb
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
What is the ticket or issue number?
Pull Request Description
Does this introduce a breaking change?
How Has This Been Tested?