Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBAPI-5253: Update Alert YAML with new fields #497

Merged
merged 9 commits into from
Apr 18, 2024

Conversation

abowersox-cb
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been added that prove the fix is effective or that the feature works.
  • New and existing tests pass locally with the changes.
  • Code follows the style guidelines of this project (PEP8, clean code, linter).
  • A self-review of the code has been done.

What is the ticket or issue number?

https://jira.carbonblack.local/browse/CBAPI-5253

Pull Request Description

Modified documentation for Alerts to include a link to the Developer Network describing all fields.

Does this introduce a breaking change?

  • Yes
  • No

How Has This Been Tested?

Unit tests run to verify slight changes to code (for generating class docstrings) had no ill effect.

src/cbc_sdk/base.py Outdated Show resolved Hide resolved
@abowersox-cb abowersox-cb merged commit c095c26 into develop Apr 18, 2024
4 checks passed
@abowersox-cb abowersox-cb deleted the CBAPI-5253_alert_yaml branch April 18, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants