Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fromResult #45

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ahmed-deftoner
Copy link

added some jsdoc for fromResult.

Copy link

changeset-bot bot commented Feb 2, 2024

⚠️ No Changeset found

Latest commit: 3987379

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@volf52
Copy link
Collaborator

volf52 commented Feb 2, 2024

Good start. Remove package-lock.json though, as yarn has been configured as the package manager for this project, and it's best to remain consistent.

@volf52
Copy link
Collaborator

volf52 commented Feb 9, 2024

@ahmed-deftoner Can you outline the impact of changing "node" to "nodenext" in tsconfig modeResolution?

@ahmed-deftoner
Copy link
Author

NodeNext has support for Node12, ESM, and CJS and it is recommended in the Typescript module resolution docs as well, especially if the module is declared as NodeNext too (which is true in this case, having a mismatch between module and module resolution may lead to inconsistent behavior). It is also meant to be a forward-looking mode that will support newer NodeJS module resolution features as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants