Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse Result.fold params #9

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Reverse Result.fold params #9

merged 2 commits into from
Nov 15, 2021

Conversation

grevend-bosch
Copy link
Contributor

Signed-off-by: David Greven fixed-term.David.Greven@de.bosch.com

@grevend-bosch
Reverse Result.fold params
8afcf3a 
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
@grevend-bosch
Update tests
f723dd9 
Signed-off-by: David Greven <fixed-term.David.Greven@de.bosch.com>
@grevend-bosch grevend-bosch added kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Nov 15, 2021
@grevend-bosch grevend-bosch self-assigned this Nov 15, 2021
@grevend-bosch grevend-bosch linked an issue Nov 15, 2021 that may be closed by this pull request
Reverse Result.fold params #10
Closed
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #9 (f723dd9) into master (135764e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #9   +/-   ##
=========================================
  Coverage     92.14%   92.14%           
  Complexity       61       61           
=========================================
  Files             7        7           
  Lines           140      140           
  Branches          6        6           
=========================================
  Hits            129      129           
  Misses            7        7           
  Partials          4        4
Impacted Files Coverage Δ
...in/java/io/carbynestack/common/result/Failure.java 100.00% <ø> (ø)
...ain/java/io/carbynestack/common/result/Result.java 100.00% <ø> (ø)
...in/java/io/carbynestack/common/result/Success.java 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 135764e...f723dd9. Read the comment docs.

sbckr
sbckr approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@sbckr sbckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbckr sbckr merged commit 0c17224 into master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbckr sbckr sbckr approved these changes

Assignees

@grevend-bosch grevend-bosch

Labels
kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reverse Result.fold params
2 participants
@grevend-bosch @sbckr