New asset_info_cache table #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New asset_info_cache table - Update rpc's where it makes sense to add decimals - New asset_info_bulk rpc that takes bulk input. Current asset_info untouched and to be phased out.
rdlrt
reviewed
Dec 8, 2022
rdlrt
force-pushed
the
asset-info-cache
branch
from
427c5cf
to
34d3f8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Where should the reviewer start?
Making sure the cache table is populated and the correctness of data.
Performance testing to make sure both cache table and rpc's perform as expected.
Motivation and context
Supporting bulk asset requests reduces the number of queries needed and the cache table helps reduce the server load for each call while adding a scheduled load.
Which issue it fixes?
#138 & #127
How has this been tested?
Tests have been done but as it adds a new cache table, updates rpc's, and has schema changes. All these things need to be verified to be correct. The asset info cache table is updated every 1 min, so new mints could take up to this limit at worst before some fields in the asset_info_bulk endpoint are populated.