New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate services logic #56

Closed

AlanVerbner opened this issue Jul 25, 2020 · 0 comments · Fixed by #121

Labels

Projects

Milestone

Preview Release

Contributor

AlanVerbner commented Jul 25, 2020

Description

Our current service-xxx functions contain two different types of logic:

response formatting (and maybe some request parameters check)
invoking proper db (repository) functions

We should separate this functions in two:

controller: handles request validation (if any not already done by our schema checks) and response formatting
services: data manipulation (cross service invocation included and db querying)

The text was updated successfully, but these errors were encountered:

AlanVerbner created this issue from a note in Rosetta API (Backlog)

AlanVerbner added the enhancement label

AlanVerbner added this to the Before Releasing milestone

AlanVerbner mentioned this issue

Change logger to be able to preserver reqId #105

Closed

AlanVerbner moved this from Backlog to In progress in Rosetta API

AlanVerbner moved this from In progress to Ready For Review in Rosetta API

AlanVerbner linked a pull request

that will close this issue

chore/56 separate services logic #121

Merged

t-dallas closed this as completed in #121

Rosetta API automation moved this from Ready For Review to Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment