chore/56 separate services logic #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
t-dallas
reviewed
Aug 24, 2020
| import { BlockService } from '../services/block-service'; | ||
| import { mapToAccountBalanceResponse } from '../utils/data-mapper'; | ||
|
|
||
| /* eslint-disable camelcase */ |
There was a problem hiding this comment.
I dont think this is necessary
t-dallas
reviewed
Aug 24, 2020
t-dallas
reviewed
Aug 24, 2020
t-dallas
reviewed
Aug 24, 2020
| request, | ||
| async () => { | ||
| const ttlOffset = request.body.options.relative_ttl; | ||
| const ttl = await (await constructionService.calculateTtl(request.log, ttlOffset)).toString(); |
There was a problem hiding this comment.
why is there two awaits? I think the one outside the parenthesis is not needed
t-dallas
reviewed
Aug 24, 2020
test/e2e/network/common.ts
Outdated
| @@ -0,0 +1,7 @@ | |||
| export const generateNetworkPayload = (blockchain: string, network: string) => ({ | |||
There was a problem hiding this comment.
there is no return type in function
t-dallas
reviewed
Aug 24, 2020
test/e2e/utils/test-utils.ts
Outdated
| @@ -29,9 +29,9 @@ export const cardanoCliMock: CardanoCli = { | |||
| export const setupServer = (database: Pool): FastifyInstance => { | |||
| const logger = configLogger(); | |||
t-dallas
force-pushed
the
chore/56-separate-services-logic
branch
from
b21d478
to
02ff90d
Compare
|
We are not being consistent with the loggeer variable name, some places is used as log.info and others as logger.info |
|
I think I replaced all the logs to |
|
@t-dallas all comments fixed! |
rhyslbw
force-pushed
the
chore/56-separate-services-logic
branch
from
ec245ba
to
81830da
Compare
|
I've run the Docker image build locally: ./scripts/build_dev_docker_images.sh
...
Successfully built f296c61e5dbe
Successfully tagged cardano-rosetta:dev
...
Successfully built f9cc3f12df98
Successfully tagged cardano-rosetta:dev-testnet |
req.log is being used to log Closes: #105
t-dallas
force-pushed
the
chore/56-separate-services-logic
branch
from
81830da
to
ccf7522
Compare
t-dallas
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a huge (but safe thanks to the tests) refactor. Due to the fact we followed
openapi-gluewe eneded up with huge modules with a lot of code. This PR tries to fix that.Also, as it was just part of following the same refactor, I introduced the refactor for #105
Sorry this PR got too big and it's not easy to review but it was a little bit cumbersome to create a PR for each module.
This PR depends on #120
Proposed Solution
Important Changes Introduced
Environment config,
TESTS_ENABLEDis no longer needed, we can just set level tosilentand it will workTesting
yarn test