Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logger to be able to preserver reqId #105

Closed
AlanVerbner opened this issue Aug 15, 2020 · 0 comments
Closed

Change logger to be able to preserver reqId #105

AlanVerbner opened this issue Aug 15, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@AlanVerbner
Copy link
Contributor

Description

We are configuring services logger instance when the app launches instead of using the one provided on each request therefore we don't get the reqId when logging making it harded to filter by request.

Proposed Solution

  • Remove logger configuration in services.ts
  • When invoking the service use as a parameter the req.log see

It might be a good idea to do this task after https://github.com/input-output-hk/cardano-rosetta/issues/56

@AlanVerbner AlanVerbner added the enhancement New feature or request label Aug 15, 2020
@AlanVerbner AlanVerbner added this to the Before Releasing milestone Aug 15, 2020
AlanVerbner added a commit that referenced this issue Aug 23, 2020
t-dallas pushed a commit that referenced this issue Aug 24, 2020
rhyslbw pushed a commit that referenced this issue Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant