-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GET http://localhost:8090/v2/network/information returns 500 on mainnet while wallet is syncing through Byron era. #1960
Comments
Should be solved by #1943 |
6 tasks
This was referenced Jul 28, 2020
lgtm |
iohk-bors bot
added a commit
that referenced
this issue
Jul 30, 2020
1977: Test getNetworkInformation handling of PastHorizonException r=Anviking a=Anviking # Issue Number #1869 / #1960 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Added a mock interpreter & network layer to produce a single unit test - [x] I think we can make this a monadic property test easily # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
iohk-bors bot
added a commit
that referenced
this issue
Jul 30, 2020
1977: Test getNetworkInformation handling of PastHorizonException r=Anviking a=Anviking # Issue Number #1869 / #1960 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Added a mock interpreter & network layer to produce a single unit test - [x] I think we can make this a monadic property test easily # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
iohk-bors bot
added a commit
that referenced
this issue
Jul 30, 2020
1977: Test getNetworkInformation handling of PastHorizonException r=Anviking a=Anviking # Issue Number #1869 / #1960 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Added a mock interpreter & network layer to produce a single unit test - [x] I think we can make this a monadic property test easily # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
iohk-bors bot
added a commit
that referenced
this issue
Jul 30, 2020
1977: Test getNetworkInformation handling of PastHorizonException r=Anviking a=Anviking # Issue Number #1869 / #1960 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Added a mock interpreter & network layer to produce a single unit test - [x] I think we can make this a monadic property test easily # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
iohk-bors bot
added a commit
that referenced
this issue
Jul 30, 2020
1977: Test getNetworkInformation handling of PastHorizonException r=Anviking a=Anviking # Issue Number #1869 / #1960 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Added a mock interpreter & network layer to produce a single unit test - [x] I think we can make this a monadic property test easily # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
iohk-bors bot
added a commit
that referenced
this issue
Jul 31, 2020
1977: Test getNetworkInformation handling of PastHorizonException r=Anviking a=Anviking # Issue Number #1869 / #1960 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Added a mock interpreter & network layer to produce a single unit test - [x] I think we can make this a monadic property test easily # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
2020.7.6 (git revision: 93c177b179fc4fc500858ebfbbf4ed7ecfc2c6bc)
Steps to Reproduce
Expected behavior
Information is available.
Actual behavior
in the log there is:
Resolution
Two separate problems:
Explanation:
startTime =<< firstSlotInEpoch (e + 1)
to get the time of the next epoch. This is just outside the horizon.network_tip
ornext_epoch
.Solution:
network_tip
andnext_epoch
optionalQA
Tested manually on mainnet.
When not in sync:
When in sync:
The text was updated successfully, but these errors were encountered: