FromMnemonic better error & fix #197
Conversation
| \your mnemonic sentence." | ||
| ErrEntropy ErrInvalidEntropyLength{} -> | ||
| "Something went wrong when trying to generate the entropy from \ | ||
| \the given mnemonic. As a user, there's nothing you can do." |
There was a problem hiding this comment.
Note that I am almost tempted to shove in a error "OMG SOMETHING WENT WRONG" here because really, we can never reach this branch. It'd mean we'd bypassed our Mnemonic type, which, as far as I am concerned, isn't possible currently.
KtorZ
force-pushed
the
KtorZ/192/from-mnemonic-errors
branch
from
6298abb
to
c0bbe07
Compare
| ErrMnemonicWords ErrWrongNumberOfWords{} -> | ||
| "Invalid number of words: at least " | ||
| <> show (natVal (Proxy :: Proxy mw)) | ||
| <> " words are expected." |
There was a problem hiding this comment.
Would it always say at least 15 for mnemonic_sentence and at least 9 for mnemonic_second_factor ?
There was a problem hiding this comment.
Also for mnemonic_second_factor (where we allow 9 or 12) it will show somewhat faulty message for, say, 15 words I suppose...
There was a problem hiding this comment.
Maybe it could be a bit more comprehensive, like:
Wrong number of words - N. Supported number of words are: mnemonic_sentence [15,18,21,24]; mnemonic_second_factor [9,12]
There was a problem hiding this comment.
Hmm.. No :)
The mnemonic length is actually encoded at the type-level here (that's what mw symbolizes) and, the error message is constructed based on this type. So, for any representation [9,12] or [15,18,21,24] or [12,18] and so forth, the error will always report on the first (smallest) length.
There was a problem hiding this comment.
Also for mnemonic_second_factor (where we allow 9 or 12) it will show somewhat faulty message for, say, 15 words I suppose...
I mean that when user provides 15 words for mnemonic_second_factor he will get Invalid number of words: at least 9 words are expected... well 15 is more than 9 so that's somewhat misleading
That's why I suggested:
Wrong number of words - N. Supported number of words are: mnemonic_sentence [15,18,21,24]; mnemonic_second_factor [9,12]
That is if you can throw in N (if not, we can drop it)
There was a problem hiding this comment.
Ah, got you! That requires slightly more work than it seems actually. Because of the way operations at the type-level work on list (at least, here), we do define instance in an inductive / recursive manner and, we "loose" (we actually consume them) some type-level information as we do it. I can try something for a few minutes, but let's scope it to 15 minutes ^^"
Issue Number
#192
Overview
Comments