Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable using script and nonextended keys #3435

Merged
merged 6 commits into from
Sep 5, 2022
Merged

Enable using script and nonextended keys #3435

merged 6 commits into from
Sep 5, 2022

Conversation

paweljakubas
Copy link
Contributor

  • Support for key hashes and non-extended public key implementation using proper bits from cardano-addresses (rather than hack)
  • ApiCredential extension, also in swagger, golden regenerated in core unit testig
  • Added comprehensive instruction and more testing in integration suite

Comments

Issue Number

adp-2114

@paweljakubas paweljakubas self-assigned this Aug 12, 2022
@paweljakubas paweljakubas marked this pull request as ready for review August 12, 2022 15:44
HeinrichApfelmus
HeinrichApfelmus approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! — I can find no obvious defects. 😊

However, the commit hash for cardano-addresses does not exist yet? 🤔

cabal.project Outdated
@@ -119,8 +119,8 @@ source-repository-package
source-repository-package
type: git
location: https://github.com/input-output-hk/cardano-addresses
tag: b7273a5d3c21f1a003595ebf1e1f79c28cd72513
--sha256: 129r5kyiw10n2021bkdvnr270aiiwyq58h472d151ph0r7wpslgp
tag: 3172d30433b4cdd9beabe6b5a0a887351f5c0061
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find this commit in the repo yet? 🤔

IntersectMBO/cardano-addresses@3172d30

@paweljakubas
Copy link
Contributor Author

this is the commit from IntersectMBO/cardano-addresses#197
Of course #197 in cardano-addresses need to be merged first, and then cardano-addresses' commit bumped once again in this PR

@paweljakubas paweljakubas force-pushed the paweljakubas/adp-2114/enable-using-script-and-nonextended-keys branch from 2e31f96 to 9dc81c6 Compare September 5, 2022 09:29
@paweljakubas
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 5, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 16cbfdc into master Sep 5, 2022
@iohk-bors iohk-bors bot deleted the paweljakubas/adp-2114/enable-using-script-and-nonextended-keys branch September 5, 2022 10:49
WilliamKingNoel-Bot pushed a commit that referenced this pull request Sep 5, 2022
docs: Merge #3435
42f2066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

@piotr-iohk piotr-iohk Awaiting requested review from piotr-iohk

Assignees

@paweljakubas paweljakubas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paweljakubas @HeinrichApfelmus