-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cardano-transactions #2164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need any bump of these in principle. But why not.
Their binaries are going to be included as release artefacts, so good to have the latest right? |
The latest release yes. Ideally, we only want to pin released versions of cardano-addresses, cardano-transactions or cardano-node. Cardano-transactions hasn't been released in a while but we're back to it and will release soon. For now, let's just bump to the latest rev. For |
7f0525e
to
21a6cf2
Compare
bors r+ |
2164: Bump cardano-transactions r=Anviking a=Anviking # Issue Number Release. # Overview - [x] Bump cardano-transactions # Comments - List of downstream PRs included in the commit messages <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 2165: Bump version to v2020-09-22 r=Anviking a=Anviking # Issue Number Release # Overview - [x] Bump version using `./scripts/make_release.sh` # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io>
This PR was included in a batch that timed out, it will be automatically retried |
2164: Bump cardano-transactions r=Anviking a=Anviking # Issue Number Release. # Overview - [x] Bump cardano-transactions # Comments - List of downstream PRs included in the commit messages <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io>
Build failed: |
bors r+ |
Build succeeded: |
Issue Number
Release.
Overview
Comments