Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cardano-transactions #2164

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Bump cardano-transactions #2164

merged 2 commits into from
Sep 22, 2020

Conversation

Anviking
Copy link
Collaborator

@Anviking Anviking commented Sep 22, 2020

Issue Number

Release.

Overview

  • Bump cardano-transactions

Comments

  • List of downstream PRs included in the commit messages

Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need any bump of these in principle. But why not.

@Anviking
Copy link
Collaborator Author

We don't need any bump of these in principle. But why not.

Their binaries are going to be included as release artefacts, so good to have the latest right?

@Anviking Anviking self-assigned this Sep 22, 2020
@KtorZ
Copy link
Member

KtorZ commented Sep 22, 2020

so good to have the latest right?

The latest release yes. Ideally, we only want to pin released versions of cardano-addresses, cardano-transactions or cardano-node. Cardano-transactions hasn't been released in a while but we're back to it and will release soon. For now, let's just bump to the latest rev. For cardano-addresses, the latest release is 2.0.0 and we don't want to bump to something more recent yet.

stack.yaml Outdated Show resolved Hide resolved
@Anviking Anviking force-pushed the anviking/v2020-09-22/bump-deps branch from 7f0525e to 21a6cf2 Compare September 22, 2020 14:26
@Anviking Anviking changed the title Bump cardano-transactions & cardano-addresses Bump cardano-transactions Sep 22, 2020
@Anviking
Copy link
Collaborator Author

bors r+

iohk-bors bot added a commit that referenced this pull request Sep 22, 2020
2164: Bump cardano-transactions r=Anviking a=Anviking

# Issue Number

Release.

# Overview

- [x] Bump cardano-transactions


# Comments

- List of downstream PRs included in the commit messages

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


2165: Bump version to v2020-09-22 r=Anviking a=Anviking

# Issue Number

Release

# Overview

- [x] Bump version using `./scripts/make_release.sh`


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
Co-authored-by: IOHK <devops+stack-project@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 22, 2020

This PR was included in a batch that timed out, it will be automatically retried

#2216

iohk-bors bot added a commit that referenced this pull request Sep 22, 2020
2164: Bump cardano-transactions r=Anviking a=Anviking

# Issue Number

Release.

# Overview

- [x] Bump cardano-transactions


# Comments

- List of downstream PRs included in the commit messages

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Johannes Lund <johannes.lund@iohk.io>
Co-authored-by: IOHK <devops+stack-project@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 22, 2020

Build failed:

#2216

@Anviking
Copy link
Collaborator Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 22, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit ffeca1d into master Sep 22, 2020
@iohk-bors iohk-bors bot deleted the anviking/v2020-09-22/bump-deps branch September 22, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants