Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bech32 Library #248

Merged
merged 23 commits into from
May 15, 2019
Merged

Bech32 Library #248

merged 23 commits into from
May 15, 2019

Commits on May 15, 2019

  1. Add original implementation.

    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    2ef9b8a View commit details
    Browse the repository at this point in the history

  2. Format imports and exports according to our coding standards.

    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    9cc1527 View commit details
    Browse the repository at this point in the history

  3. Format code according to our coding standards.

    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    5e1ef5c View commit details
    Browse the repository at this point in the history

  4. Use <$> instead of fmap .. $.

    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    8101b63 View commit details
    Browse the repository at this point in the history

  5. Import Data.ByteString.Char8 as B8 rather than BSC.

    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    8addb76 View commit details
    Browse the repository at this point in the history

  6. Add original unit test source code.

    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    f984bb0 View commit details
    Browse the repository at this point in the history

  7. Format test code to meet our coding standards.

    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    dd2f49b View commit details
    Browse the repository at this point in the history

  8. Format imports and exports according to our coding standards.

    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    a7b78b7 View commit details
    Browse the repository at this point in the history

  9. Change constraint from Num to Integral.

    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    4b6311f View commit details
    Browse the repository at this point in the history

  10. Shorten length of Word5 constructor from UnsafeWord5 to Word5. 

    This makes code more concise, but doesn't affect safety, as this constructor is
not exported outside of the `Codec.Binary.Bech32` module.
    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    a5807d1 View commit details
    Browse the repository at this point in the history

  11. Move brackets to avoid unnecessary $.

    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    0b2ad65 View commit details
    Browse the repository at this point in the history

  12. Import Data.ByteString.Char8 as B8 rather than BSC.

    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    7c1b9e8 View commit details
    Browse the repository at this point in the history

  13. add module description and author credits on top of the file

    @KtorZ @jonathanknowles
    KtorZ authored and jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    cd03189 View commit details
    Browse the repository at this point in the history

  14. replace usage of 'tasty' by 'hspec' in lib/bech32

    @KtorZ @jonathanknowles
    KtorZ authored and jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    1642cc7 View commit details
    Browse the repository at this point in the history

  15. remove bitcoin-specific details and provide a slightly more general API

    @KtorZ @jonathanknowles
    KtorZ authored and jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    6ac2d5a View commit details
    Browse the repository at this point in the history

  16. add QuickCheck roundtrip for encode . decode

    @KtorZ @jonathanknowles
    KtorZ authored and jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    37af224 View commit details
    Browse the repository at this point in the history

  17. Add roundtrip tests for toBase256 and toBase32 functions.

    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    e5a4574 View commit details
    Browse the repository at this point in the history

  18. Add roundtrip tests for character set conversion functions.

    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    5e40f85 View commit details
    Browse the repository at this point in the history

  19. Add QuickCheck tests for convertBits function.

    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    9c8c5b0 View commit details
    Browse the repository at this point in the history

  20. Introduce humanReadableCharset{Min,Max}Bound constants. 

    Use these constants instead of repeating the same hard-coded values in
different places.
    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    97d2358 View commit details
    Browse the repository at this point in the history

  21. Introduce constants checksumLength and maxEncodedStringLength. 

    Use these constants to avoid repeatedly hardcoding the same values
within functions.
    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    0fdc8bb View commit details
    Browse the repository at this point in the history

  22. Improve documentation comment for function convertBits.

    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    e31048b View commit details
    Browse the repository at this point in the history

  23. Split module Bech32 into public API and private Internal module.

    @jonathanknowles
    jonathanknowles committed May 15, 2019
    Configuration menu
    Copy the full SHA
    9374258 View commit details
    Browse the repository at this point in the history