Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fingerprint assertions to list/get endpoints in integration tests #2520

Merged
merged 1 commit into from
Feb 15, 2021
Merged

Add fingerprint assertions to list/get endpoints in integration tests #2520

merged 1 commit into from
Feb 15, 2021

Conversation

piotr-iohk
Copy link
Contributor

Issue Number

ADP-703

Overview

  • Add fingerprint assertions to list/get endpoints in integration tests

Comments

@piotr-iohk piotr-iohk self-assigned this Feb 15, 2021
KtorZ
KtorZ approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui.

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 15, 2021
@iohk-bors
Merge #2520
aca9d33 
2520: Add fingerprint assertions to list/get endpoints in integration tests r=piotr-iohk a=piotr-iohk

# Issue Number

ADP-703


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Add fingerprint assertions to list/get endpoints in integration tests


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 15, 2021 •
edited by rvl

Build failed:

     CONNECT /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/2147483647
     TRACE /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/2147483647
     OPTIONS /wallets/0000000000000000000000000000000000000000/signatures/utxo_internal/2147483647
     PUT /wallets/0000000000000000000000000000000000000000/statistics/utxos
     POST /wallets/0000000000000000000000000000000000000000/statistics/utxos
     PATCH /wallets/0000000000000000000000000000000000000000/statistics/utxos
     DELETE /wallets/0000000000000000000000000000000000000000/statistics/utxos
building of '/nix/store/m549nn2z1qjcv2iqi62i1lifvzrs9l71-cardano-wallet-core-test-unit-2021.2.12-check' timed out after 900 seconds of silence

#2472

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 15, 2021
@iohk-bors
Merge #2520
14dff27 
2520: Add fingerprint assertions to list/get endpoints in integration tests r=piotr-iohk a=piotr-iohk

# Issue Number

ADP-703


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Add fingerprint assertions to list/get endpoints in integration tests


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 15, 2021 •
edited by rvl

Build failed:

        +++ OK, passed 100 tests; 8 discarded.
    can't put before wallet exists
      Checkpoint
        +++ OK, passed 100 tests.
      Wallet Metadata
        +++ OK, passed 100 tests.
      Tx History
        +++ OK, passed 100 tests.
      Private Key
        +++ OK, passed 100 tests.
    put doesn't affect other resources
building of '/nix/store/djzhldcr0bj58i7w79dckq0lww3cr0q4-cardano-wallet-core-test-unit-2021.2.12-check' timed out after 900 seconds of silence

#2472

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 15, 2021
@iohk-bors
Merge #2520
2326bab 
2520: Add fingerprint assertions to list/get endpoints in integration tests r=piotr-iohk a=piotr-iohk

# Issue Number

ADP-703


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Add fingerprint assertions to list/get endpoints in integration tests


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 15, 2021 •
edited by rvl

Build failed:

Failures:

  src/Test/Integration/Scenario/API/Shelley/Transactions.hs:351:22:
  1) API Specifications, SHELLEY_TRANSACTIONS, TRANS_CREATE_01x - Single Output Transaction
       While verifying (Status {statusCode = 200, statusMessage = "OK"},Right (ApiWallet {id = ApiT {getApiT = WalletId {getWalletId = fc1ad1b9bd319948e638749cfe6798e87b5d5324}}, addressPoolGap = ApiT {getApiT = AddressPoolGap {getAddressPoolGap = 20}}, balance = ApiWalletBalance {available = Quantity {getQuantity = 1869500}, total = Quantity {getQuantity = 1869500}, reward = Quantity {getQuantity = 0}}, assets = ApiWalletAssetsBalance {available = ApiT {getApiT = TokenMap (fromList [])}, total = ApiT {getApiT = TokenMap (fromList [])}}, delegation = ApiWalletDelegation {active = ApiWalletDelegationNext {status = NotDelegating, target = Nothing, changesAt = Nothing}, next = []}, name = ApiT {getApiT = WalletName {getWalletName = "Empty Wallet"}}, passphrase = Just (ApiWalletPassphraseInfo {lastUpdatedAt = 2021-02-15 18:53:57.984466 UTC}), state = ApiT {getApiT = Ready}, tip = ApiBlockReference {absoluteSlotNumber = ApiT {getApiT = SlotNo 2866}, slotId = ApiSlotId {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 57}}, slotNumber = ApiT {getApiT = SlotInEpoch {unSlotInEpoch = 16}}}, time = 2021-02-15 18:54:38.2 UTC, block = ApiBlockInfo {height = Quantity {getQuantity = 1292}}}}))
       expected: Quantity {getQuantity = 0}
        but got: Quantity {getQuantity = 1869500}

  To rerun use: --match "/API Specifications/SHELLEY_TRANSACTIONS/TRANS_CREATE_01x - Single Output Transaction/"

#2467

@rvl
Copy link
Contributor

rvl commented Feb 15, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 15, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit a37c985 into master Feb 15, 2021
@iohk-bors iohk-bors bot deleted the piotr/fingerprint_assertions branch February 15, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

Assignees

@piotr-iohk piotr-iohk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@piotr-iohk @rvl @KtorZ