Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various reward-related flaky tests #2467

Closed
Anviking opened this issue Jan 26, 2021 · 2 comments
Closed

Various reward-related flaky tests #2467

Anviking opened this issue Jan 26, 2021 · 2 comments
Labels
Test failure A flaky test or nightly CI failure

Comments

@Anviking
Copy link
Collaborator

Context

#2449 recently changed core logic in the network layer.

Very rarely, this failure appeared on the branch:

  src/Test/Integration/Framework/DSL.hs:1796:7:
  2) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_JOIN_01rewards - Can join a pool, earn rewards and collect them
       expected a successful response but got an error: DecodeFailure "{\"code\":\"created_invalid_transaction\",\"message\":\"That's embarrassing. It looks like I've created an invalid transaction that could not be parsed by the node. Here's an error message that may help with debugging: HardForkApplyTxErrFromEra S (S (S (Z (WrapApplyTxErr {unwrapApplyTxErr = ApplyTxError [LedgerFailure (DelegsFailure (WithdrawalsNotInRewardsDELEGS (fromList [(RewardAcnt {getRwdNetwork = Mainnet, getRwdCred = KeyHashObj (KeyHash \\\"56e36e911d28670c50eaf7169e507bc1422162d3eb8a3c9982e2f95d\\\")},Coin 19675454185)])))]}))))\"}"
       While verifying (Status {statusCode = 500, statusMessage = "Internal Server Error"},Left (DecodeFailure "{\"code\":\"created_invalid_transaction\",\"message\":\"That's embarrassing. It looks like I've created an invalid transaction that could not be parsed by the node. Here's an error message that may help with debugging: HardForkApplyTxErrFromEra S (S (S (Z (WrapApplyTxErr {unwrapApplyTxErr = ApplyTxError [LedgerFailure (DelegsFailure (WithdrawalsNotInRewardsDELEGS (fromList [(RewardAcnt {getRwdNetwork = Mainnet, getRwdCred = KeyHashObj (KeyHash \\\"56e36e911d28670c50eaf7169e507bc1422162d3eb8a3c9982e2f95d\\\")},Coin 19675454185)])))]}))))\"}"))

  To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_JOIN_01rewards - Can join a pool, earn rewards and collect them/"

though I have also seen it once before.

After merging it, there seem to be an uptick in failures related to withdrawals.

Need to investigate, but might be that the reward balance is less consistently updated when the wallet is under high load (as in integration tests), since #2449.

Test Case

Multiple, related to withdrawals.

Failure / Counter-example


Resolution


QA

@Anviking
Copy link
Collaborator Author

Skärmavbild 2021-06-14 kl  21 30 43

Hoping this is fixed by #2698. Can re-open if not.

@jonathanknowles
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test failure A flaky test or nightly CI failure
Projects
None yet
Development

No branches or pull requests

2 participants