Update release scripts #2628
Merged
Update release scripts #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
force-pushed
the
rvl/release-scripts
branch
from
06382da
to
d8a6499
Compare
sevanspowell
approved these changes
Apr 28, 2021
rvl
force-pushed
the
rvl/release-scripts
branch
2 times, most recently
from
9345ab0
to
35cdbca
Compare
iohk-bors bot
added a commit
to input-output-hk/iohk-nix
that referenced
this pull request
Apr 29, 2021
471: Clean up haskell-nix-extra-packages r=rvl a=rvl Follow-ups from PR #468. - Removes the `haskell-nix-extra-packages` attrset - it's not needed anywhere and didn't work anyway. - Expose `project` and `mkProject` attributes of `pkgs.haskellBuildUtils`. This would let downstream users generate materializations, etc, etc. Tested on cardano-foundation/cardano-wallet#2628. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
iohk-bors bot
added a commit
to input-output-hk/iohk-nix
that referenced
this pull request
Apr 29, 2021
471: Clean up haskell-nix-extra-packages r=rvl a=rvl Follow-ups from PR #468. - Removes the `haskell-nix-extra-packages` attrset - it's not needed anywhere and didn't work anyway. - Expose `project` and `mkProject` attributes of `pkgs.haskellBuildUtils`. This would let downstream users generate materializations, etc, etc. Tested on cardano-foundation/cardano-wallet#2628. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
rvl
force-pushed
the
rvl/release-scripts
branch
3 times, most recently
from
d0c01f5
to
fdccffb
Compare
Moves implementation details into a "private" attribute.
rvl
force-pushed
the
rvl/release-scripts
branch
from
adec568
to
442d31b
Compare
They were using the full store path of the exe, which was wrong.
rvl
force-pushed
the
rvl/release-scripts
branch
3 times, most recently
from
5ab2faf
to
69d3cb4
Compare
rvl
force-pushed
the
rvl/release-scripts
branch
from
69d3cb4
to
ae36c1a
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-894
Overview
default.nixattributes into public and private, to help users know what names are stable.Comments
Hydra jobset