Reduce nix closure size of set-git-rev #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With cardano-wallet, I noticed that build dependencies of set-git-rev were not cached. Furthermore some of these dependencies were python ← bzr ← nix-prefetch-scripts. The problem is nixpkgs `callCabal2nix`, so this replaces it with Haskell.nix. There are other things in `haskell-nix-extra` which can be deprecated, so I have removed them with deprecation errors traced where possible.
Merged
iohk-bors bot
added a commit
that referenced
this pull request
Apr 29, 2021
471: Clean up haskell-nix-extra-packages r=rvl a=rvl Follow-ups from PR #468. - Removes the `haskell-nix-extra-packages` attrset - it's not needed anywhere and didn't work anyway. - Expose `project` and `mkProject` attributes of `pkgs.haskellBuildUtils`. This would let downstream users generate materializations, etc, etc. Tested on cardano-foundation/cardano-wallet#2628. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
iohk-bors bot
added a commit
that referenced
this pull request
Apr 29, 2021
471: Clean up haskell-nix-extra-packages r=rvl a=rvl Follow-ups from PR #468. - Removes the `haskell-nix-extra-packages` attrset - it's not needed anywhere and didn't work anyway. - Expose `project` and `mkProject` attributes of `pkgs.haskellBuildUtils`. This would let downstream users generate materializations, etc, etc. Tested on cardano-foundation/cardano-wallet#2628. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With cardano-wallet, I noticed that build dependencies of
set-git-revwere not cached. Furthermore some of these dependencies werepython←bzr←nix-prefetch-scripts.The problem is nixpkgs
callCabal2nix, so this replaces it with Haskell.nix.There are other things in
haskell-nix-extrawhich can be deprecated, so I have removed them with deprecation errors traced where possible.Comments
This PR will stay draft until I have made and fully tested the corresponding update in cardano-wallet.